Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate transaction broadcast errors to openContractCall #261

Open
2snEM6 opened this issue Jul 21, 2022 · 1 comment
Open

Propagate transaction broadcast errors to openContractCall #261

2snEM6 opened this issue Jul 21, 2022 · 1 comment
Labels

Comments

@2snEM6
Copy link

2snEM6 commented Jul 21, 2022

Right now there is now way to know if a transaction has been rejected by the API.
It would be useful if calls such as openContractCall would include an onFailure callback or similar that gets fired whenever there is an issue.

@whoabuddy
Copy link

whoabuddy commented Jul 21, 2022

Relaying a comment from @aulneau in Discord:

yeah, this is something i've run into in the past, it's so hard to debug
onFailure seems like it might make sense, was thinking about how it'd be nice to have these three:

onSuccess - meaning it's a correct transaction, and it's been broadcast
onFailure - failed for some reason
onCancel - user ends session before completing any action

i'm not sure this would make sense for message signing though, but it could

I think this makes a lot of sense too, it'd be nice to be able to target each state with a specific strategy on the UI/UX side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants