During slide discovery prefer natural ordering of numbers #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not anymore necessary to use fixed-width numbers (001, 024, 100) to move 24 before 100 during slide loading. The one liner sort() function is courtesy of https://stackoverflow.com/a/14599441/4620544 Fixes #598
|
It seems it needs a bit more of fine-tuning because in sub-directories the ordering is still non-natural or it fails when function parameters are null. Since I don't have time now to fix the PR, I close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not anymore necessary to use fixed-width numbers (001, 024, 100) to move 24 before 100 during slide loading.
The one liner sort() function is courtesy of https://stackoverflow.com/a/14599441/4620544
Fixes #598
It's necessary to regenerate the cache (node_modules/.cache) for this PR to make effect.
Motivation / Use-Case
See #598 for motivation.