Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couchbase: disabled #46

Closed
pascalgrimaud opened this issue Mar 29, 2020 · 10 comments · Fixed by jhipster/generator-jhipster#11583
Closed

Couchbase: disabled #46

pascalgrimaud opened this issue Mar 29, 2020 · 10 comments · Fixed by jhipster/generator-jhipster#11583

Comments

@pascalgrimaud
Copy link
Member

Disabled at f5dbe94

The integration tests are too flatky.
See :

cc @tchlyah -> as you're our main contributor on Couchbase
cc @SudharakaP -> as I know you already spent a lot of time on this

@SudharakaP
Copy link
Member

@pascalgrimaud : Let me take another look as well; I think we didn't have a final solution the last time. 😄

@pascalgrimaud
Copy link
Member Author

@SudharakaP : don't spend time on this, I'm pretty sure it will be fixed soon
See testcontainers/testcontainers-java#2491

@SudharakaP
Copy link
Member

SudharakaP commented Apr 5, 2020 via email

@DanielFran
Copy link
Contributor

@pascalgrimaud should we disable also couchbase on webflux workflow in main generator?

@pascalgrimaud
Copy link
Member Author

@DanielFran : if it failed a lot, yes

SudharakaP added a commit to SudharakaP/jhipster that referenced this issue Apr 13, 2020
This updates the TestContainers dependency to 1.14.0

Related to hipster-labs/jhipster-daily-builds#46
@SudharakaP
Copy link
Member

SudharakaP commented Apr 13, 2020

testcontainers/testcontainers-java#2491 is now merged and they released a new version https://github.com/testcontainers/testcontainers-java/releases/tag/1.14.0. But I don't see it on sonatype yet. Does it take some time before it's available? 🤔

cc: @bsideup

@SudharakaP
Copy link
Member

SudharakaP commented Apr 13, 2020

Ah now it's available. So I've went ahead and updated it; we shall see if this fixes our problems. 😄

EDIT: I need to do some more updates since the api seems to have changed. Will do it soon. 😄

@SudharakaP
Copy link
Member

I've upgraded testcontainers and adjusted the Couchbase testing to conform to the new api. Please let me know if you see any issues. 😄

SudharakaP added a commit to SudharakaP/jhipster-daily-builds that referenced this issue Apr 14, 2020
This re-enables Couchbase since we have upgraded testcontainers to 1.14.0 and hopefully this solves Couchbase issues.

Related to hipster-labs#46
@bsideup
Copy link

bsideup commented Apr 14, 2020

@SudharakaP I hope the change was painless :) Please let us know if you experience any issues with the new implementation 👍

@SudharakaP
Copy link
Member

@bsideup ; Thanks Sergei. 😄 Yes it wasn't difficult. We will soon see how the new implementation works when the daily builds starts to run. 😄

vishal423 pushed a commit to vishal423/jhipster that referenced this issue Jun 21, 2020
This updates the TestContainers dependency to 1.14.0

Related to hipster-labs/jhipster-daily-builds#46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants