Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/inline prop #30

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Feat/inline prop #30

wants to merge 7 commits into from

Conversation

demetrius-mp
Copy link
Contributor

adds suport for inline prop
closes #5

himynameisdave
himynameisdave reviewed Sep 16, 2022
View reviewed changes
Copy link
Owner

@himynameisdave himynameisdave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! This appears to include your changes from #29, so I'll go review that one first.

@himynameisdave himynameisdave added the enhancement New feature or request label Sep 16, 2022
@demetrius-mp
Copy link
Contributor Author

i forgot to add the new props on the readme section

@himynameisdave
Copy link
Owner

himynameisdave commented Sep 16, 2022 •
edited

i forgot to add the new props on the readme section

@demetrius-mp Good catch, do you mind adding that here, as well as in #29 ?

@demetrius-mp
Copy link
Contributor Author

ok, ill add them

@demetrius-mp demetrius-mp mentioned this pull request Sep 16, 2022
Open
@demetrius-mp
Copy link
Contributor Author

sorry, i definetly messed up something when doing the branches thing. im new to open source 😅

i think that if you close #29 and merge only this PR, it will be ok, since this PR has the commits from #29.

this PR has

  • inline prop with its tests, and also declared on the readme
  • gap prop with its tests, the adjustments suggested here, and also declared on the readme

@himynameisdave
Copy link
Owner

i think that if you close #29 and merge only this PR,

I'd rather have each of these props included as separate commits (makes it easier to revert if there are any issues, plus I it's a nicer commit history to keep things separated). Please address the final comments in #29 and then we can take a look at this PR :)

@demetrius-mp
Copy link
Contributor Author

ok!

@himynameisdave
Copy link
Owner

@demetrius-mp same comment as here, sorry! #29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himynameisdave himynameisdave himynameisdave left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support inline-flex
2 participants
@demetrius-mp @himynameisdave