Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite to communicate for @joshgoebel #17

Closed
Serhioromano opened this issue Jan 24, 2021 · 5 comments
Closed

Invite to communicate for @joshgoebel #17

Serhioromano opened this issue Jan 24, 2021 · 5 comments

Comments

@Serhioromano
Copy link
Collaborator

@joshgoebel

Thank you for response first of all. But i am completely lost how to add my own language. In extra/3RD_PARTY_QUICK_START.md file is a very controversial and convoluted information.

  1. It shows as example separate repositories like mine but suggest to checkout HLJS repo and add folder to extra folder
  2. It suggests adding folder extra/iecst in my case but later when run build it says it will generate extra/highlightjs-iecst/dist/iecst.min.js file. So, it is a different folder name.
  3. In instruction is say create file in src/languages but why then create separate repository?
@joshgoebel
Copy link
Member

joshgoebel commented Jan 24, 2021

In instruction is say create file in src/languages but why then create separate repository?

Answered elsewhere. Reference: highlightjs/highlight.js#2149

It suggests adding folder extra/iecst in my case but later when run build it says it will generate extra/highlightjs-iecst/dist/iecst.min.js file. So, it is a different folder name.

The name isn't relevant at all.

Whatever you name the folder is where it will place the dist folder. Then you just add it and commit it, done.

@Serhioromano
Copy link
Collaborator Author

@joshgoebel do you mean that I use HLJS main repository to generate dist/*min.js and then I move it to my repository and comit?

@joshgoebel
Copy link
Member

joshgoebel commented Jan 25, 2021

Not exactly.

You check out your repository INSIDE the HLJS repository, inside extra. That's what the extra folder is for.

Then you use the normal HLJS build process and it will find any 3rd party modules inside extra and build them as well (if requested).

Then there is no need to "move" anything. You just git add and git commit it.

@Serhioromano
Copy link
Collaborator Author

Done. Now iv'got it. Updated to new version now. Hope this is how it should be now.

@joshgoebel
Copy link
Member

Looks good.

You shouldn't need the iecst.js in your root anymore though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants