Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to the thought process for 3rd party language packaging if you'd like #1

Closed
joshgoebel opened this issue Dec 20, 2019 · 6 comments

Comments

@joshgoebel
Copy link
Member

Contribute to the thought process for 3rd party language packaging if you'd like

As a maintainer of a Highlight.js language grammar you might be interested in the discussion of an official packaging format. I just created an issue to track the discussion and I've been working on this along with the new build system.

highlightjs/highlight.js#2328

Sorry for the spam, but I couldn't think of an easier way to ping the people who might be most interested in weighing in on the subject. Feel free to simply close this issue or leave it open (whatever works best for you!).

@pedro-w
Copy link
Collaborator

pedro-w commented Jun 22, 2021

closed because highlightjs/highlight.js#3008 has been resolved.

@pedro-w pedro-w closed this as completed Jun 22, 2021
@gusbemacbe
Copy link

@joshgoebel, does the repo highlightjs-cypher need to be updated?

@joshgoebel
Copy link
Member Author

@gusbemacbe

  • hljs.initHighlightingOnLoad() has been deprecated.
  • charset="UTF-8" isn't necessary for minified distributables - they are ASCII now

@gusbemacbe
Copy link

* `hljs.initHighlightingOnLoad()` has been deprecated.

I will check your documentation to replace it.

@gusbemacbe
Copy link

I will replace it with hljs.highlightAll(), right, @joshgoebel ?

@joshgoebel
Copy link
Member Author

Yep.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants