Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(misc) Misc fixes from looking at LGTM #2852

Merged
merged 3 commits into from Nov 15, 2020
Merged

fix(misc) Misc fixes from looking at LGTM #2852

merged 3 commits into from Nov 15, 2020

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 12, 2020 •
edited

Changes

  • minor linting fixes
  • fix(r) fixed keywords not properly spaced
  • fix(javascript) final solid fix for runaway regex
  • fix(livescript) fix potential catastrophic backtracking

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel added this to the 10.4 milestone Nov 14, 2020
@joshgoebel joshgoebel added this to Remaining in 10.4 Nov 14, 2020
@joshgoebel
Copy link
Member Author

@allejo @egor-rogov If either of you find more time I created a board of what's holding up 10.4:

https://github.com/highlightjs/highlight.js/projects/2

egor-rogov
egor-rogov approved these changes Nov 14, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@joshgoebel joshgoebel merged commit dc7a81e into highlightjs:master Nov 15, 2020
@joshgoebel joshgoebel deleted the lgtm branch November 15, 2020 03:50
@bichikim bichikim mentioned this pull request Nov 25, 2020
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Nov 25, 2020
Merged
This was referenced Mar 9, 2021
Merged
Merged
Closed
Closed
Merged
Open
Merged
Merged
Open
Open
Closed
Open
Open
This was referenced Mar 14, 2021
Merged
Merged
Open
Closed
Open
Merged
Open
Open
Open
Merged
Closed
Open
Open
Open
Open
Open
Open
Merged
Open
Merged
Merged
Open
Open
Closed
Closed
Open
Merged
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

@egor-rogov egor-rogov egor-rogov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
10.4
Remaining
Milestone
10.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joshgoebel @allejo @egor-rogov