From e0e09b3e86f808ae797ed6e9c213e66903bc5543 Mon Sep 17 00:00:00 2001 From: Michael Rush Date: Fri, 30 Oct 2020 16:45:49 -0700 Subject: [PATCH 1/3] Corrected typo in Vue plugin setting detectedLanguage Fixed typo `this.detectectLanguage` -> `this.detectedLanguage` when rendering content when a language has been provided. In that case detectedLanguage was not getting set, which meant the computed className was also not getting the language. --- src/plugins/vue.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/vue.js b/src/plugins/vue.js index dee6e833a4..e61346fab2 100644 --- a/src/plugins/vue.js +++ b/src/plugins/vue.js @@ -33,7 +33,7 @@ export const Component = { this.detectedLanguage = result.language; } else { result = hljs.highlight(this.language, this.code, this.ignoreIllegals); - this.detectectLanguage = this.language; + this.detectedLanguage = this.language; } return result.value; }, From 02916b278de8a986f5c6b60884dc740c60bb0265 Mon Sep 17 00:00:00 2001 From: Michael Rush Date: Mon, 2 Nov 2020 10:20:50 -0800 Subject: [PATCH 2/3] Updated AUTHORS.txt and CHANGES.md for pr-2807 --- AUTHORS.txt | 1 + CHANGES.md | 6 ++++++ 2 files changed, 7 insertions(+) diff --git a/AUTHORS.txt b/AUTHORS.txt index 7b48423b6e..d6daaeeddd 100644 --- a/AUTHORS.txt +++ b/AUTHORS.txt @@ -295,3 +295,4 @@ Contributors: - Richard Gibson - Fredrik Ekre - Jan Pilzer +- Michael Rush diff --git a/CHANGES.md b/CHANGES.md index 1421151217..6688766005 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -24,6 +24,12 @@ New themes: [Jan Pilzer]: https://github.com/Hirse +Vue Plugin +- Fixed a typo in the Vue plugin that caused `detectedLanguage` not to get set +when a language was provided, causing the language CSS class to be missing from +the computed the CSS classname(s). + + ## Version 10.3.1 Prior version let some look-behind regex sneak in, which does not work From d0c765ac80448ce4910ab2151eef4e0695c7fc31 Mon Sep 17 00:00:00 2001 From: Josh Goebel Date: Mon, 2 Nov 2020 14:30:32 -0500 Subject: [PATCH 3/3] Update CHANGES.md --- CHANGES.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 8de519998c..67b5ce4a78 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,6 +1,10 @@ ## Version 10.4.0 (work in process) -New languages: +Parser: + +- fix(vue): Language name now appears in CSS class (#2807) [Michael Rush][] + +New Languages: - Added Chapel grammar to SUPPORTED_LANGUAGES (#2806) [Brad Chamberlain][] @@ -29,12 +33,7 @@ New themes: [Taufik Nurrohman]: https://github.com/taufik-nurrohman [Jan Pilzer]: https://github.com/Hirse [Jonathan Sharpe]: https://github.com/textbook - - -Vue Plugin -- Fixed a typo in the Vue plugin that caused `detectedLanguage` not to get set -when a language was provided, causing the language CSS class to be missing from -the computed the CSS classname(s). +[Michael Rush]: https://github.com/rushimusmaximus ## Version 10.3.1