Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flix to SUPPORTED_LANGUAGES.md #3637

Merged
merged 7 commits into from
Nov 1, 2022
Merged

Add Flix to SUPPORTED_LANGUAGES.md #3637

merged 7 commits into from
Nov 1, 2022

Conversation

jaschdoc
Copy link
Contributor

@jaschdoc jaschdoc commented Oct 16, 2022

Changes

This PR adds the Flix language to the list of supported languages.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

This PR adds the Flix language to the list of supported languages.
@jaschdoc jaschdoc marked this pull request as ready for review October 16, 2022 13:27
@joshgoebel
Copy link
Member

Please include a common JS CDN build in the dist folder of your repo so users who know and care nothing about build systems can just drop a single file into their website that "just works".

If you follow the recommended build process we generate this file automatically.

@jaschdoc
Copy link
Contributor Author

jaschdoc commented Oct 18, 2022

Should this file also include the common languages (built by node tools/build.js -t cdn :common)? Nevermind, I figured it out :)

CHANGES.md Outdated Show resolved Hide resolved
@jaschdoc
Copy link
Contributor Author

Ready for review. Thank you for your patience :)

@joshgoebel
Copy link
Member

How would you feel about renaming the repo to highlightjs-flix for parity with all the others?

@jaschdoc
Copy link
Contributor Author

How would you feel about renaming the repo to highlightjs-flix for parity with all the others?

We've now renamed the repo to highlightjs-flix.

@joshgoebel joshgoebel merged commit e0f7577 into highlightjs:main Nov 1, 2022
@joshgoebel
Copy link
Member

Thanks!

@jaschdoc jaschdoc deleted the patch-1 branch November 1, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants