Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New intellij-light Theme #3433

Merged
merged 2 commits into from Dec 27, 2021

Conversation

PegasisForever
Copy link
Contributor

Added intellij-light theme

Changes

New intellij-light theme

Checklist

  • Added markup tests, or they don't apply here because it is a theme
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Please attach the output from our check theme utility.

@PegasisForever
Copy link
Contributor Author

PegasisForever commented Dec 24, 2021

$ ./tools/checkTheme.js src/styles/intellij-light.css
Accessibility Report
┌───────┬────────────────────────────────────────┬──────────┬──────────┐
│ ratio │ selector                               │ fg       │ bg       │
│ 21    │ .hljs                                  │ #000     │ #fff     │
│ 21    │ .hljs-subst,.hljs-title                │ #000     │ #fff     │
│ 4.48  │ .hljs-title.function_                  │ #7A7A43  │ #fff     │
│ 3.36  │ .hljs-code,.hljs-comment,.hljs-quote   │ #8C8C8C  │ #fff     │
│ 3.51  │ .hljs-meta                             │ #9E880D  │ #fff     │
│ 8.29  │ .hljs-section                          │ #871094  │ #fff     │
│ 9.88  │ .hljs-variable.language_,.hljs-symbol… │ #0033B3  │ #fff     │
│ 8.29  │ .hljs-property,.hljs-attr              │ #871094  │ #fff     │
│ 7.08  │ .hljs-attribute                        │ #174AD4  │ #fff     │
│ 6.21  │ .hljs-number                           │ #1750EB  │ #fff     │
│ 5.81  │ .hljs-regexp                           │ #264EFF  │ #fff     │
│ 5.17  │ .hljs-link                             │ #006DCC  │ #fff     │
│ 5.31  │ .hljs-meta .hljs-string,.hljs-string   │ #067D17  │ #fff     │
│ 10.01 │ .hljs-char.escape_                     │ #0037A6  │ #fff     │
│ 3.89  │ .hljs-template-variable                │ #248F8F  │ #fff     │
│ 15.25 │ .hljs-addition                         │ #000     │ #BEE6BE  │
│ 14.45 │ .hljs-deletion                         │ #000     │ #D6D6D6  │
└───────┴────────────────────────────────────────┴──────────┴──────────┘

.hljs-variable,
.hljs-operator,
.hljs-punctuation,
.hljs-title.class_.inherited__,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're intentionally choosing to ignore class names?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes because in intellij light these class names use the default black style.

.hljs-params,
.hljs-bullet,
.hljs-formula,
.hljs-tag {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show a snap of this highlighting XML or HTML... tag is usually pretty important...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't tag just the part around the tag (*<* div *>*)? The div inside it has class name hljs-name so it will get highlighted. The < and > around the tag uses default styling in intellij-light.
image

@joshgoebel
Copy link
Member

@PegasisForever Thanks so much!

@joshgoebel joshgoebel merged commit c0138d9 into highlightjs:main Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants