Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve checkTheme script #3425

Open
joshgoebel opened this issue Dec 9, 2021 · 0 comments
Open

Improve checkTheme script #3425

joshgoebel opened this issue Dec 9, 2021 · 0 comments
Labels

Comments

@joshgoebel
Copy link
Member

joshgoebel commented Dec 9, 2021

See also: #3402 (comment)

We have some themes that use rgba(), will .hex() work on those values?


Two notes on this one:

  1. Some styles use background-color to differentiate the background for specific elements. I think we should add support for checking background-color for WCAG contrast.

    .hljs-regexp {
    background-color: #fff0ff;
    color: #880088;
    }

  2. Should we have a minimum Node defined somewhere for dev environments? Optional chaining was added in Node 14 and our package.json requires Node 12+ (correctly so, for our users).

Originally posted by @allejo in #3402 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant