Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(nsis) Update language string pattern #3420

Merged
merged 4 commits into from Dec 6, 2021
Merged

enh(nsis) Update language string pattern #3420

merged 4 commits into from Dec 6, 2021

Conversation

idleberg
Copy link
Contributor

@idleberg idleberg commented Dec 4, 2021

Updates pattern for NSIS language strings to allow !-characters. This is basically the same as #3417, but for language strings. Unfortunately, I can't produce any example to back this up.

Changes

Allow ! in language strings regex pattern

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel
Copy link
Member

Unfortunately, I can't produce any example to back this up.

Then how do we know this is needed at all? I'm a little confused. :)

@idleberg idleberg changed the title Add GetWinVer enh(nsis) Update language string pattern Dec 4, 2021
@idleberg
Copy link
Contributor Author

idleberg commented Dec 4, 2021

Then how do we know this is needed at all? I'm a little confused. :)

It's too unusual to find results in the wild (I tried both the NSIS wiki and GitHub's code search), but it's valid code. I created a demo repository where such code is compiled in a GitHub action. If ! wasn't valid, the compiler would throw an error.

@joshgoebel joshgoebel merged commit 91c5228 into highlightjs:main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants