Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(js/ts) improve CLASS_REFERENCE #3411

Merged
merged 6 commits into from Dec 9, 2021
Merged

enh(js/ts) improve CLASS_REFERENCE #3411

merged 6 commits into from Dec 9, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Nov 29, 2021 •
edited

Resolves #3403.

Changes

  • improves CLASS_NAME_REFERNCE rule to catch more edge cases

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel changed the title enh(js/ts) improve CLASS_REFERANCE, add TS keywords enh(js/ts) improve CLASS_REFERENCE Dec 8, 2021
allejo
allejo requested changes Dec 9, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the edge case of a class matching the "CSSFactory" rule and ending with an uppercase letter; e.g. HTTPResponseT or IResponseTsS

image

@joshgoebel
Copy link
Member Author

Better?

allejo
allejo approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@joshgoebel joshgoebel merged commit ba806ed into highlightjs:main Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(TypeScript) Camel-case type parameters: only first component is highlighted
2 participants
@joshgoebel @allejo