Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(java) add sealed and non-sealed keywords #3386

Merged
merged 5 commits into from Nov 3, 2021

Conversation

bradleymackey
Copy link
Contributor

@bradleymackey bradleymackey commented Nov 2, 2021

Adds support for these missing keywords, using a different matching pattern for hyphenated keywords as a workaround. Source for suggested workaround.

Changes

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@bradleymackey bradleymackey changed the title enh(java) add support sealed and non-sealed keywords enh(java) add sealed and non-sealed keywords Nov 2, 2021
src/languages/java.js Outdated Show resolved Hide resolved
Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but lets make the one change suggested.

@joshgoebel joshgoebel merged commit 99e05df into highlightjs:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Java) Java 17 sealed keywords not implemented
2 participants