Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CSS) Inline comments are not highlighted correctly (regression between 10.5.0 and 10.6.0) #3299

Closed
deniskovalchuk opened this issue Aug 2, 2021 · 3 comments · Fixed by #3301
Labels
bug help welcome Could use help from community language

Comments

@deniskovalchuk
Copy link
Contributor

Describe the issue

Inline comments are not highlighted correctly starting from hljs 10.6.0 (new highlightAll API).

Which language seems to have the issue?

CSS

Are you using highlight or highlightAuto?

highlightAll

Sample Code to Reproduce

Version 11.1.0 (using highlightAll):
https://jsfiddle.net/7eu8pdkx/

Version 10.5.0 (using initHighlighting):
https://jsfiddle.net/3brz5gk9/

Expected behavior

expected

Actual behavior

actual

@deniskovalchuk deniskovalchuk added bug help welcome Could use help from community language labels Aug 2, 2021
@deniskovalchuk deniskovalchuk changed the title (CSS) Inline comments are not highlighted correctly (CSS) Inline comments are not highlighted correctly (regression between 10.5.0 and 10.6.0) Aug 2, 2021
@joshgoebel
Copy link
Member

Could you have a look at #3301?

@deniskovalchuk
Copy link
Contributor Author

I've tested #3301 in my production environment and it fixes the issue for me, thanks.

@joshgoebel
Copy link
Member

Thanks, assigned it for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug help welcome Could use help from community language
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants