Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(markdown) Images with empty alt or links with empty text #3233

Merged
merged 3 commits into from Jun 14, 2021
Merged

fix(markdown) Images with empty alt or links with empty text #3233

merged 3 commits into from Jun 14, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Jun 7, 2021 •
edited

Resolves #3232.

Changes

  • Properly highlights links with empty alt or text descriptions

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel requested a review from allejo June 13, 2021 13:43
allejo
allejo reviewed Jun 13, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue at hand 👍 Do we want to take into consideration linkable images, which is currently not accurate?

image

@joshgoebel
Copy link
Member Author

Do we want to take into consideration linkable images, which is currently not accurate?

We could open a new issue for that if you'd like. I have no idea what the nesting rules even are or how common that is.

@joshgoebel joshgoebel merged commit 2dd87a6 into highlightjs:main Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(markdown) Images with empty alt or links with empty text do not have highlight
2 participants
@joshgoebel @allejo