Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docs) Non-minified files are UTF-8, minified are ASCII #3220

Closed
joshgoebel opened this issue Jun 2, 2021 · 1 comment
Closed

(docs) Non-minified files are UTF-8, minified are ASCII #3220

joshgoebel opened this issue Jun 2, 2021 · 1 comment
Labels
autoclose Flag things to future autoclose. docs/website help welcome Could use help from community

Comments

@joshgoebel
Copy link
Member

joshgoebel commented Jun 2, 2021

I'd like to note that ascii_only: true is a terser-only option, so the non-minified files may contain arbitrary UTF-8 chars.

Originally posted by @aduh95 in #3209 (comment)


We may need to take some action on this knowledge...

@joshgoebel
Copy link
Member Author

joshgoebel commented Jun 4, 2021

% file build/highlight.min.js                                                                             
build/highlight.min.js: ASCII text, with very long lines
% file build/highlight.js                                                                                   
build/highlight.js: UTF-8 Unicode text, with very long lines

Confirm. Since this:

  • hasn't been an actual issue for anyone (people are using minified, as they should)
  • Can be resolved with the HTML attribute charset
  • UTF-8 is the future
  • Web servers should also be providing this via HTTP headers

... I'm declaring the existing behavior correct and this should be a docfix if at all.

The minified file is provided ASCII only for convenience. The non-minified file is intentional UTF-8.

@joshgoebel joshgoebel added docs/website help welcome Could use help from community labels Jun 4, 2021
@joshgoebel joshgoebel changed the title Non-minified files are not guaranteed ASCII (docs) Non-minified files are UTF-8, minified are ASCII Jun 4, 2021
@joshgoebel joshgoebel added the autoclose Flag things to future autoclose. label Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autoclose Flag things to future autoclose. docs/website help welcome Could use help from community
Projects
None yet
Development

No branches or pull requests

1 participant