Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) remove meta-keyword and meta-string in favor of nesting #3167

Merged
merged 5 commits into from May 14, 2021
Merged

(chore) remove meta-keyword and meta-string in favor of nesting #3167

merged 5 commits into from May 14, 2021

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Apr 23, 2021 •
edited

Resolves #3163.

Checklist

  • Added markup tests, or they don't apply here because...
  • Updated the changelog at CHANGES.md

@joshgoebel joshgoebel marked this pull request as draft April 23, 2021 20:00
@joshgoebel joshgoebel added this to the 11.0 beta 0 milestone Apr 23, 2021
@joshgoebel joshgoebel mentioned this pull request Apr 24, 2021
Open
@joshgoebel joshgoebel modified the milestones: 11.0 beta 0, 11.0 May 2, 2021
@joshgoebel joshgoebel marked this pull request as ready for review May 13, 2021 23:26
@joshgoebel joshgoebel requested a review from allejo May 13, 2021 23:26
allejo
allejo approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope you don't mind I pushed to your branch. Doing a "replace all" was easier than doing suggestions on here.

LGTM 👍

@joshgoebel
Copy link
Member Author

Oh it was because my search and replace didn't care about the quoting. I see now. :)

@joshgoebel joshgoebel merged commit b54b866 into highlightjs:main May 14, 2021
@Hirse Hirse mentioned this pull request May 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

Review/fix meta, meta-string, and meta-keyword scopes
2 participants
@joshgoebel @allejo