Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Kotlin) kts is not recognized #3021

Closed
AlexCzar opened this issue Feb 25, 2021 · 3 comments · Fixed by #3022
Closed

(Kotlin) kts is not recognized #3021

AlexCzar opened this issue Feb 25, 2021 · 3 comments · Fixed by #3022
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language

Comments

@AlexCzar
Copy link

AlexCzar commented Feb 25, 2021 •
edited

Describe the issue
hljs.getLanguage("kts") cannot find Kotlin language.

Which language seems to have the issue?
Kotlin

Are you using highlight or highlightAuto?

highlight

Sample Code to Reproduce

hljs.getLanguage("kt"); // works
hljs.getLanguage("kotlin"); // works
hljs.getLanguage("kts"); // doesn't work

example:
https://jsfiddle.net/tao605qL/55/

Expected behavior
hljs.getLanguage("kts"); should return "Kotlin" language.
@AlexCzar AlexCzar added bug help welcome Could use help from community language labels Feb 25, 2021
@joshgoebel
Copy link
Member

PR welcome.

@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Feb 25, 2021
il3ven added a commit to il3ven/highlight.js that referenced this issue Feb 25, 2021
@il3ven
fix(kotlin) Add kts as an alias for Kotlin (highlightjs#3021)
45522f5
@il3ven il3ven mentioned this issue Feb 25, 2021
Merged
3 tasks
joshgoebel pushed a commit that referenced this issue Feb 25, 2021
@il3ven
enh(kotlin): Add kts as an alias for Kotlin (#3021) (#3022)
5b3a22e
@AlexCzar
Copy link
Author

Thanks. If I knew tests were not required, I would've submitted the PR myself :D

@joshgoebel
Copy link
Member

We don't require tests for adding a single new alias.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(kotlin): Add kts as an alias for Kotlin (#3021) il3ven/highlight.js
2 participants
@joshgoebel @AlexCzar