[PHP] Add support for Enum #3004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP 8.1 adds support for Enums with [`enum` syntax](https://php.watch/versions/8.1/enums#enum-syntax). Adding `enum` keyword to class naming pattern matches, and relaxing the class structure matching to allow `:` character to support Backed-Enum syntax.
Brilliant suggestion by @joshgoebel to use variants with different `illegal` matching patterns. Enums can contain a colon, but not other class-like structs such as `trait`, `interface`, and `class`. Co-authored-by: Josh Goebel <me@joshgoebel.com>
|
RFC vote ended with 44:7 in favor. PHP 8.1 will have Enums 🎉🎊. |
joshgoebel
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2997.
PHP 8.1 will add support for Enums with a syntax similar to this:
At the moment, the vote has two more days to end, but it already has the 2/3 majority it requires to pass. This PR includes changes that did not make it to #2997 because the vote has yet to end. Once the vote is concluded, I will mark mark this PR ready for review, although early reviews are received with so much gratitude!
Changes
Checklist
CHANGES.mdAUTHORS.txt, under Contributors