Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Bring all the grammars up to a standard level of Lint compliance #2854

Closed
8 tasks done
joshgoebel opened this issue Nov 12, 2020 · 0 comments · Fixed by #2853
Closed
8 tasks done

Cleanup: Bring all the grammars up to a standard level of Lint compliance #2854

joshgoebel opened this issue Nov 12, 2020 · 0 comments · Fixed by #2853
Labels

Comments

@joshgoebel
Copy link
Member

joshgoebel commented Nov 12, 2020

This is part of the larger task of auditing all the grammars for incorrect or exponential backtracking regex. To make those PRs simpler and easier to review we first clean them up with eslint --fix.

I've been against these type of sweeping changes in the past without good reason, but if we have to touch every single file anyways to clean up the regex (so it can be properly audited) then we may as well lint them first to make that job easier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant