Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(parser) use negative look-ahead for beginKeywords #2813

Merged
merged 5 commits into from Nov 13, 2020
Merged

enh(parser) use negative look-ahead for beginKeywords #2813

merged 5 commits into from Nov 13, 2020

Conversation

joshgoebel
Copy link
Member

@joshgoebel joshgoebel commented Oct 31, 2020 •
edited

Changes

Just realized we only need the callback for the look-behind, we can use actual
regex to look-ahead.

Checklist

  • Existing test coverage
  • Updated the changelog at CHANGES.md
  • Added myself to AUTHORS.txt, under Contributors

@joshgoebel joshgoebel added the WIP label Nov 1, 2020
@joshgoebel joshgoebel removed the WIP label Nov 3, 2020
@joshgoebel joshgoebel added this to the 10.4 milestone Nov 12, 2020
egor-rogov
egor-rogov approved these changes Nov 13, 2020
View reviewed changes
Copy link
Collaborator

@egor-rogov egor-rogov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
(suddenly ran out of free time, will try to catch up slowly...)

@joshgoebel joshgoebel merged commit c776c4b into highlightjs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egor-rogov egor-rogov egor-rogov approved these changes

@allejo allejo Awaiting requested review from allejo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshgoebel @egor-rogov