Add Chapel as a supported third-party language #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
|
I dunno about authors (I won't stop ya, but I've never really thought about it), but you can definitely add an entry to the changelog if you'd like! |
--- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
|
@joshgoebel: I added a CHANGES.md entry as suggested. I skipped the AUTHORS.md update, but can do it if you prefer. Let me know if there are any other changes required before this is merged (Travis testing is still pending as I write this). [Also, in other news, I successfully got our Discourse site using Chapel highlighting even without this being merged which I consider a major win] |
joshgoebel
reviewed
Nov 2, 2020
joshgoebel
approved these changes
Nov 2, 2020
|
Thanks Josh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2800
Changes
This adds an entry for the Chapel language, giving
chapelandchplas its two aliases, and pointing to our repo at https://github.com/chapel-lang/highlightjs-chapel.Checklist
CHANGES.mdAdded myself to(wasn't certain whether adding a third-party package warranted being added to AUTHORS.txt and @joshgoebel didn't seem certain either)AUTHORS.txt, under Contributors[Note: I haven't done the last two items because it's not clear to me whether they apply to something as minor as adding a new third-party language to the list. Please let me know]