Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(php) highlight variables #2785

Merged
merged 8 commits into from Oct 27, 2020
Merged

enh(php) highlight variables #2785

merged 8 commits into from Oct 27, 2020

Conversation

taufik-nurrohman
Copy link
Member

@taufik-nurrohman taufik-nurrohman commented Oct 25, 2020 •
edited

Resolve #2778

Checklist

  • Tested.
  • Updated the changelog at CHANGES.md

joshgoebel
joshgoebel reviewed Oct 25, 2020
View reviewed changes
src/languages/php.js Outdated Show resolved Hide resolved
@joshgoebel
Copy link
Member

You'll also need to update the tests in markup/php to match your grammar change.

joshgoebel
joshgoebel requested changes Oct 25, 2020
View reviewed changes
Copy link
Member

@joshgoebel joshgoebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update according to notes. Thanks!

@joshgoebel joshgoebel changed the title Highlight PHP Variable enh(php) highlight variables Oct 25, 2020
@joshgoebel
Copy link
Member

Please finish checklist! Looking good!

@joshgoebel joshgoebel added the hacktoberfest-accepted Hacktoberfest label Oct 27, 2020
@joshgoebel
Copy link
Member

@taufik-nurrohman Thanks so much!

@joshgoebel joshgoebel merged commit 95ad819 into highlightjs:master Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(php) variables should be highlighted as variable
2 participants
@taufik-nurrohman @joshgoebel