enh(xml) deprecate ActionScript inside script tags #2444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
deprecate_actionscript
branch
from
0765931
to
b2d7cbe
Compare
egor-rogov
approved these changes
Mar 1, 2020
I actually don't view this as a breaking change in the same way as the other things - we've done similar things (removing vbscript from the same list) in minor releases. I view this as more of a maintenance item.
I haven't decided how to do that yet. Maybe - or I might end up moving the whole breaking changes content into the changelog before the actual release. If not, yes a link would make sense. |
joshgoebel
added a commit
that referenced
this pull request
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1212.