fix(elixir) Support function names with a slash #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not mistakenly recognize `/:` as the beginning of a regex, which causes highlighting to abort. - `/:`, `+:`, are still not considered symbols This solves the problem by making the `/: \d` an exception case that is never treated as a regex. For most cases, most of the time this should be a win. Resolves highlightjs#730.
3 tasks
allejo
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/:as the beginning of a regex,which causes highlighting to abort.
/:,+:, are still not considered symbolsThis solves the problem by making the pattern
/: \d+an exceptional case that isnever treated as a regex. For most cases, most of the time this should be a win - as in the
use of these short functional symbols is much more common than an actual regex that starts with a literal like
/: 2etc.Resolves #730.