enh(zephir) almost complete rework of the zephir grammar #2387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original grammar was lifted from PHP and is inaccurate. - does not support hash style comments - does not have `__halt_compiler`
joshgoebel
changed the title
taufik-nurrohman
pushed a commit
to taufik-nurrohman/highlight.js
that referenced
this pull request
Feb 18, 2020
…#2387) * (chore) zephir grammar cleanups and more The original grammar was lifted from PHP and is inaccurate in many ways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous grammar was based on PHP and had a lot of incorrect
pieces and left over PHP junk. This PR attemps to entirely rework
the grammar to actually only support Zephir, and remove all the
old PHP pieces.