enh(parser) better regular expression detection #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fewer false positives - Uses a look-ahead to make sure we have a WHOLE regex and not just a partial (which is more likely a math expression)
|
This paired with the "value" container support (and smart rule ordering) in JS actually catches a lot of common cases: `Bad ${foo / 1000}`
foo = 2 / 2 + 2 / 2;
foo = / 2 + 2 /;
b = a++ / 2;All of these just work (which is even better than Github). So I think this is enough to close that issue until we have more real life examples that fail (new issues), and then review this again. |
taufik-nurrohman
pushed a commit
to taufik-nurrohman/highlight.js
that referenced
this pull request
Feb 18, 2020
* enh(parser) better regular expression detection - fewer false positives - Uses a look-ahead to make sure we have a WHOLE regex and not just a partial (which is more likely a math expression)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a partial (which is more likely a math expression)
Closes #2050.