enh(parser) simplify nohighlight #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now only `no-highlight` and `nohighlight` skip a block entirely - `plain` will do nothing - `text` is now an alias for `plaintext` Closes highlightjs#2363.
|
@egor Any ideas on betting naming for I decided to make both configurable while I was in there since it was easy and it's come up in conversation before. |
|
I hadn't considered uses like (from the removed tests): <pre><code class="text-content javascript">var x = 'foo';</code></pre>
<pre><code class="clipboard-text javascript">var x = 'foo';</code></pre>But think it's still safe to consider them deprecated for the brutal consistency of "nohighlight". And if anyone is seriously affected they can just use the configuration option. |
egor-rogov
requested changes
Feb 6, 2020
egor-rogov
approved these changes
Feb 6, 2020
taufik-nurrohman
pushed a commit
to taufik-nurrohman/highlight.js
that referenced
this pull request
Feb 18, 2020
* (chore) make `noHighlightRe` and `languagePrefixRe` configurable (languageDetectRe now) * (chore) simply 'nohighlight' regex - Now only `no-highlight` and `nohighlight` skip a block entirely - `plain` will do nothing - `text` is now an alias for `plaintext` Closes highlightjs#2363.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.