Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added php7 to php classes list in readme #2349

Merged
merged 2 commits into from Jan 15, 2020
Merged

Conversation

dmyers
Copy link
Contributor

@dmyers dmyers commented Jan 10, 2020

No description provided.

@joshgoebel
Copy link
Member

Does anyone use all these variants anyways? I've always wondered. I think the idea was for it to be the file extension, but do people use php* as the file extension in real life anyways?

@joshgoebel joshgoebel merged commit 892c16d into highlightjs:master Jan 15, 2020
@dmyers
Copy link
Contributor Author

dmyers commented Jan 15, 2020

Sorry I forgot to reply on this but basically you are right I think, I haven't seen usage of the .php$version usage since php3 days, but I did wonder if it could be useful for some code syntax differences. I tried highlight.js with some newer PHP 7 syntax changes like newer typehints and they weren't highlighted yet.

@joshgoebel
Copy link
Member

I can't see us maintaining separate grammars for different versions, so we'd always track the latest... if you see issues with parsing you could file an issue with specific examples. I went ahead and merged this since we already have php7 as an alias anyways so we're down that rabbit hole whether we should be or not. :-)

So at least now our docs are consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants