(clojure) Add support for global definitions name (class: title)

[agrison]

Adds support for Clojure global definitions name with class name title, including:

• def
• defonce
• defprotocol
• defstruct
• defmulti
• defmethod
• defn
• defn-
• defmacro
• deftype
• defrecord

[joshgoebel]

Wouldn't this patch remove the need for NAME and BODY?

[joshgoebel]

Please also add a changelog entry.

[joshgoebel]

Missing a space here.

If these so different might one of the other keyword classes be more appropriate also?

[joshgoebel]

I don't think this is correct. - is not the title. You'll need to update lexeme so it can match keywords that include '.

[joshgoebel]

Ping.

[agrison]

Thanks for the feed-back it's my first time on highlightjs so didn't knew all the specifics I'll update with changes whenever I do have some free time :)

[joshgoebel]

Ping.

[joshgoebel]

Ping. Still out there?

[joshgoebel]

Ping.

[agrison]

Hello.

Yes still out there, sorry for the delay, I've been busy and couldn't work on this.

Sadly, yesterday I tried but I don't know enough about the inners of the library to make it work like you need to, I tried moving some definitions, modify the lexeme but to no avail, it always break something else, and I don't have much time to investigate for this.

[joshgoebel]

Ok, Clojure actually is kind of a mess... and you might also be hitting an actual issue/bug with HLJS in that beginKeywords wants keywords to end on a word boundary but the "space" between - and (space) is NOT considered a word boundary evidentally... so it fails to match on: defn-... but that's only part of the problem...

The grammar is making a mess of things by trying to count almost everything as a NAME or a SYMBOL... which I'm pretty sure is wrong, and definitely not consistent with how we do other grammars...

But if you want to help, lets try and start on fixing some smaller things I see first... then maybe after we clean it up a bit we can circle back to this.

First question:

(def +x [(a 1) +2 -3.0 y-5])

What is -5 there? The grammar right now identifies y-5 as a symbol because...

var SYMBOLSTART = 'a-zA-Z_\\-!.?+*=<>&#\'';
var SYMBOL_RE = '[' + SYMBOLSTART + '][' + SYMBOLSTART + '0-9/;:]*';
  
var SYMBOL = {
    begin: SYMBOL_RE,
    relevance: 0
  };

• Is y-5 truly an identifier/variable all on it's own or is that actually y - 5 (y subtract 5)?
• Can a variable/identifier TRULY start with - as part of the name? That would seem very confusing.
• Do you have any idea what the NAME rule is trying to accomplish?

[joshgoebel]

I might be getting the naming confused... we also have keys, which get the class symbol... but that's not what I'm talking about here. I'm talking about the literal rule that I show the source for above.

[agrison]

Well Clojure is not really a mess, the syntax is simple and easy to pick-up, of course it can be a little disturbing the first times.

In your example y-5 is a valid symbol identifier in Clojure, if you wanted y minus 5 it would have been written (- y 5)

Yes a symbol can start with a minus or a plus character.

user=> (def y-5 7)
#'user/y-5
user=> (+ y-5 2)
9
user=> (def -foo "hello")
#'user/-foo
user=> (str -foo " world")
"hello world"
user=> (def -+* (+10 11))
#'user/-+*
user=> (def *-+ 21)
#'user/*-+
user=> (+ -+* *-+)
42

You're probably right, maybe the highlightjs parser is having some limitations that needs to be fixed prior to scan correctly clojure code. But it could also be that I don't know how to use it correctly to find the symbol boundaries effectively.

[joshgoebel]

Whoops, I accidentally pushed your master back to upstream/master instead of pushing my branch to yours - I forget the syntax cause I rarely do it - and now I can't push it because the PR is closed and the magic permissions go away.

I will re-open a new PR.

[joshgoebel]

#2419

[joshgoebel]

@agrison LOL. No I didn't mean Clojure was a mess, I meant the grammar was... though it makes a little more sense with our explanation. Anyways I went back over this and tried to just do the minimal amount to make this work for now.

Basically that meant making sure title only fires a single time and also removing some pieces of your rule that don't seem to have any real effect.