Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Fortran block statement. #2343

Merged
merged 4 commits into from Jan 3, 2020
Merged

Added Fortran block statement. #2343

merged 4 commits into from Jan 3, 2020

Conversation

interkosmos
Copy link
Contributor

Added block keyword, as described in issue #2342.

@joshgoebel
Copy link
Member

joshgoebel commented Jan 2, 2020 •
edited

Please add to CHANGELOG.

Is the endblock form without a space also allowed? I see a lot of other keywords done like that.

@joshgoebel joshgoebel added enhancement An enhancement or new feature language labels Jan 2, 2020
@joshgoebel joshgoebel self-requested a review January 2, 2020 22:59
@interkosmos
Copy link
Contributor Author

interkosmos commented Jan 2, 2020 •
edited

Is the endblock form without a space also allowed? I see a lot of other keywords done like that.

Yes, endblock is accepted, even if end block should be preferred.

@joshgoebel
Copy link
Member

You'll need to add endblock as a keyword also then.

@interkosmos
Copy link
Contributor Author

Can I somehow change the current PR?

@joshgoebel
Copy link
Member

Just add a second commit.

@joshgoebel
Copy link
Member

Yep. Nice. Now just a CHANGES entry please.

@joshgoebel
Copy link
Member

@interkosmos Thanks so much for this contribution!

@joshgoebel joshgoebel merged commit 42f1df4 into highlightjs:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshgoebel joshgoebel joshgoebel approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature language
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@interkosmos @joshgoebel