enh(cpp) Improve function declaration detection #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
cpp_function_fixes
branch
2 times, most recently
from
9f66b73
to
cc2bd25
Compare
egor-rogov
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
See some comments, but generally it's all good.
Looks like it will interfere with #2325 though.
- enh(cpp) Properly detect decltype(auto) - enh(cpp) recognize primitive types (`int8_t`, etc.) as function types
joshgoebel
force-pushed
the
cpp_function_fixes
branch
from
757fba6
to
0e09a67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int8_t, etc.) as function typesA::typeName func(...))A::functionName)vector<int> func(...))Closes #1730.
Closes #1222.
Closes #1502.