(javascript) fix jsx self-closing tag issues #2322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgoebel
force-pushed
the
jsx_fixes
branch
from
ea6a183
to
82a1217
Compare
joshgoebel
force-pushed
the
jsx_fixes
branch
from
494cb66
to
8924ae5
Compare
joshgoebel
force-pushed
the
jsx_fixes
branch
from
8924ae5
to
042479b
Compare
luisherranz
reviewed
Dec 16, 2019
| @@ -6,6 +6,8 @@ Website: https://developer.mozilla.org/en-US/docs/Web/JavaScript | |||
| */ | |||
|
|
|||
| function(hljs) { | |||
| var TAG_START = /<[A-Za-z0-9\\._:-]+/; | |||
| var TAG_FINISH = /\/[A-Za-z0-9\\._:-]+>|\/>/; | |||
There was a problem hiding this comment.
Hey guys, React now support fragments which are usually written as <>...</>.
So maybe this could be
var TAG_START = /<[A-Za-z0-9\\._:-]*/;
var TAG_FINISH = /\/[A-Za-z0-9\\._:-]*>|\/>/;What do you think? Do you see any problem?
There was a problem hiding this comment.
I think I need an actual real example of what you're talking about.
There was a problem hiding this comment.
Well now if that ain't just ridiculous. :-)
https://reactjs.org/docs/fragments.html#short-syntax
Could you open an actual issue for this, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1915.