enh(stan) updated with improved coverage of language keywords and patterns. #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Almost complete rewrite. Corrected most patterns and updated function definitions. - Add "stanfuncs" as an alias
marcoscaceres
approved these changes
Oct 8, 2018
|
Thanks @jrnold! Would you by chance be willing to be the maintainer of Stan's syntax highlighting? If so, I can spin up a repository in the highlightjs organization. It would mean you could update the language independently of hljs core. |
|
@jrnold You still out there? Any thoughts about being maintainer for this? |
joshgoebel
requested changes
Oct 11, 2019
|
This language is already in the core. Why should we move it away? |
|
Moving this to the language discussion. |
|
Since this is already in core though I was moving forward with reviewing it as if it was mergeable since it looks good to me... what to do long-term is a separate discussion. |
|
Bumping this from 9.15.11. |
|
@jrnold You still around? Would love to work on this with you and get it merged... |
|
@jrnold Ping. |
joshgoebel
approved these changes
Dec 24, 2019
joshgoebel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definitions.
This PR fixes the botched rebase in #1755.