Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot compile trust-dns-proto v0.18.0-alpha.1 #931

Closed
ebroto opened this issue Nov 26, 2019 · 8 comments · Fixed by #932
Closed

Cannot compile trust-dns-proto v0.18.0-alpha.1 #931

ebroto opened this issue Nov 26, 2019 · 8 comments · Fixed by #932

Comments

@ebroto
Copy link

ebroto commented Nov 26, 2019

First of all, thanks for these awesome crates!

While trying to build the resolver lib as a dependency, I'm getting the following error:

   Compiling trust-dns-proto v0.18.0-alpha.1
error[E0432]: unresolved import `tokio_net::tcp`
   --> /home/ebroto/.cargo/registry/src/github.com-1ecc6299db9ec823/trust-dns-proto-0.18.0-alpha.1/src/tcp/tcp_client_stream.rs:128:16
    |
128 | use tokio_net::tcp::TcpStream as TokioTcpStream;
    |                ^^^ could not find `tcp` in `tokio_net`

error[E0432]: unresolved import `tokio_net::udp`
   --> /home/ebroto/.cargo/registry/src/github.com-1ecc6299db9ec823/trust-dns-proto-0.18.0-alpha.1/src/udp/udp_stream.rs:316:5
    |
316 | use tokio_net::udp;
    |     ^^^^^^^^^^^^^^ no `udp` in the root

error: aborting due to 2 previous errors

It seems to be related to the release of tokio 0.2.0. Yesterday it was building fine.

@bluejekyll
Copy link
Member

Yes, I have a local branch I'm working on right now for this.

@bluejekyll
Copy link
Member

There are a lot of changes since the last alpha... btw, this might take me a little bit.

@bluejekyll
Copy link
Member

waiting on this to be merged and released, it's blocking this change: tokio-rs/tokio#1826

@soyflourbread
Copy link

It is already merged BTW

@bluejekyll
Copy link
Member

thanks, tokio 0.2.1 was just published. I'll have master up to date soon, and then can publish 0.18.0-alpha.2 as well.

@bluejekyll
Copy link
Member

this is taking a little longer than anticipated. tokio change a few things that have broken different components of the system.

@bluejekyll
Copy link
Member

bluejekyll commented Nov 27, 2019

Ok, #932 should work for most cases, but before it can be merged with need tokio-rustls to be updated (needed for dns-over-tls with rustls and dns-over-https)

@ebroto
Copy link
Author

ebroto commented Dec 6, 2019

Thanks for all the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants