Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate all Vec usage and replace with SmallVec where apropriate #365

Open
bluejekyll opened this issue Mar 27, 2018 · 3 comments · May be fixed by #1974
Open

Evaluate all Vec usage and replace with SmallVec where apropriate #365

bluejekyll opened this issue Mar 27, 2018 · 3 comments · May be fixed by #1974

Comments

@bluejekyll
Copy link
Member

Make sure to run benchmarks before and after to see if there is a difference ;)

This should reduce heap allocations throughout the various libraries.

@link2xt
Copy link

link2xt commented Nov 23, 2021

For some reason there is also a tinyvec dependency already. tinyvec is a safer alternative to smallvec:
https://www.reddit.com/r/rust/comments/n2429h/arrayvec_vs_smallvec_vs_tinyvec/

Which one to use depends on actual performance of course, but would be nice to choose one and have a single dependency.

@djc
Copy link
Collaborator

djc commented Nov 24, 2021

See some discussion in #1388.

If you want to rip out uses of smallvec in favor of tinyvec, that'd be great!

@darnuria
Copy link
Contributor

Hi @bluejekyll /@djc, have some time this end of the month if still pertinent i can try to claim the task and do something to only use tinyvec ! :)

(maybe a renaming of the ticket or opening a new one if neccessary)

@darnuria darnuria linked a pull request Jun 20, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants