Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/test compilation error in client when only enabling feature dns-over-https #2115

Open
alexanderkjall opened this issue Dec 24, 2023 · 2 comments

Comments

@alexanderkjall
Copy link
Contributor

Describe the bug

The dns-over-https feature relies on rustls.

To Reproduce
Steps to reproduce the behavior:

In the crates/client/ directory:

$ cargo build --no-default-features --features dns-over-https
   Compiling hickory-client v0.24.0 (/home/capitol/project/hickory-dns/crates/client)
error[E0432]: unresolved import `rustls`
  --> crates/client/src/h2_client_connection.rs:16:5
   |
16 | use rustls::ClientConfig;
   |     ^^^^^^ help: a similar path exists: `hickory_proto::rustls`

For more information about this error, try `rustc --explain E0432`.
error: could not compile `hickory-client` (lib) due to previous error

Expected behavior

that cargo build / cargo test works

System:

  • OS: Arch
  • Architecture: x86_64
  • Version n/a
  • rustc version: 1.74.1

Version:
Crate: client
Version: git

Additional context
n/a

@djc
Copy link
Collaborator

djc commented Jan 9, 2024

I think this might be similar to #2066, #2067, #2090?

@alexanderkjall
Copy link
Contributor Author

Yes, these things might have the same underlying cause. I'm not really familiar enough with the codebase to have an opinion on that.

Feel free to close this if you feel that it's a duplicate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants