Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistency: install_command configured in tox.ini should more closely correspond to the default tox install command #699

Closed
jayaddison opened this issue Dec 13, 2022 · 1 comment

Comments

@jayaddison
Copy link
Collaborator

In particular, these lines don't include the -I (as in the first letter of Indigo) isolated-mode flag for Python, that tox includes by default.

recipe-scrapers/tox.ini

Lines 13 to 14 in baf3403

install_command =
py-darwin: python -m pip install --only-binary=lxml {opts} {packages}

(these lines introduced by https://github.com/hhursev/recipe-scrapers/pull/650/files#diff-ef2cef9f88b4fe09ca3082140e67f5ad34fb65fb6e228f119d3812261ae51449R14-R15)

To fix #698, one possible short-term solution could be to provide a install_command for the environment name py. That's not ideal, because it should be kept up-to-date with any changes to the tox install default, and could diverge if it doesn't (extra maintenance burden / tech debt). If we're doing that, we should match the current defaults.. and when inspecting those, I noticed that the py-darwin environment isn't consistent.

@jayaddison
Copy link
Collaborator Author

Resolved by #702.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant