Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added briceletbaklava.ch #697

Merged
merged 7 commits into from Dec 13, 2022
Merged

added briceletbaklava.ch #697

merged 7 commits into from Dec 13, 2022

Conversation

lacliq
Copy link
Contributor

@lacliq lacliq commented Dec 12, 2022

No description provided.

@jayaddison
Copy link
Collaborator

Thanks @lacliq - this looks pretty good to me: I'll add some review comments in a few moments.

Also: I'm not yet sure what is causing the continuous integration checks to fail on Ubuntu and Windows.

@jayaddison
Copy link
Collaborator

Also: I'm not yet sure what is causing the continuous integration checks to fail on Ubuntu and Windows.

Opened issue #698 to track this.

lacliq and others added 2 commits December 13, 2022 18:03
@lacliq @jayaddison
Update recipe_scrapers/briceletbaklava.py
44f37fa 
Co-authored-by: James Addison <55152140+jayaddison@users.noreply.github.com>
@lacliq
return list of string
792daf1 
category, ingredients and ingredients function now return list of string instead string with \n
@jayaddison
Copy link
Collaborator

@lacliq looks like you might have pushed some unrelated code/files here by accident?

I've found a short-term solution for the continuous integration check failures in #702, so we should be able to run the tests against your changes soon.

@lacliq
Copy link
Contributor Author

lacliq commented Dec 13, 2022

oups ...

@jayaddison
Copy link
Collaborator

jayaddison commented Dec 13, 2022 •
edited

Ok, nearly ready! Two small items remaining to fix:

  • category and instructions should have '\n'.join(...) re-added - they should return strings
  • run black and flake8 and ensure that both of those pass

@lacliq
return string & formatting
4f6bcd3 
- black formatting + flake8 check
- category & instructions return string
@jayaddison
Copy link
Collaborator

Looks good to me - thank you! Running the tests again... 🤞

@jayaddison
Copy link
Collaborator

Nice work - thank you, @lacliq 👍

@jayaddison jayaddison merged commit 472114b into hhursev:main Dec 13, 2022
jayaddison pushed a commit that referenced this pull request Dec 16, 2022
@lacliq @jayaddison
added briceletbaklava.ch (#697)
0435c2f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayaddison jayaddison jayaddison left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lacliq @jayaddison