Add Project Gezond scraper (Dutch Website) #691
Conversation
|
Thanks @NijeboerFrank for your contribution! This implementation looks really good to me. One nitpick I had was about the
That's ok - this library is here to help with situations like that :)
One more item I noticed: we could replace |
| def yields(self): | ||
| # Match everything in the h2 with 'Dit heb je nodig' | ||
| # The text inside the parentheses contains the yield for the ingredients that are listed | ||
| return re.search( |
There was a problem hiding this comment.
One more thing to keep in mind - hopefully not important in this case, but in general - and sorry if I'm explaining things that you understand already, but it's worth being careful to limit what regular expressions can match on, and/or how much input text they are provided as input.
Just something I repeat (no pun intended) at nearly every available opportunity 😄
There was a problem hiding this comment.
Thanks for your advice! I'm not really that familiar with regular expressions, so all tips are appreciated 😄
|
This looks good to me - thanks again @NijeboerFrank. I'll plan to merge and release this in the nearish future (possibly not today, but should be within the next few days otherwise). |
Thanks for this project! I use it a lot on my Mealie instance.
This PR contains a Dutch recipe site that I use sometimes (Link). Sadly the site did not have a nice way of using the schema nor did the HTML have useful class names, so my implementation might seem a bit hacky.
Feedback is appreciated to improve the implementation!