New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 646/scraper weightwatchers #657
Issue 646/scraper weightwatchers #657
Conversation
…/bickerdyke/recipe-scrapers into issue-646/scraper_weightwatchers update local branch
I changed the code according to the suggestions, except the array comment where I had no idea if I should check array size or handle an exception |
Looks good to me, thanks! 🍻 I'll merge and bump version this weekend. I like the
note and we'll start using it going forwards. Would you mind sharing how you use the package? Looks like you are downloading a file + scrape the html separately. Your input will help us determine what updates to implement. |
Saving a file html file from Browser and have that scraped is what I did for development and I let the test class feed it to the scraper. |
I'm slightly uneasy about supporting login-required scrapers (even when offline), partly because of the test data alongside each scraper. Currently those test files are retrieved from public websites - anyone could/should see the same results, and anyone can later check/update/fix the scraper by retrieving it again. |
Add scrapers for weight watchers public and restricted recipes.
fixes #646