Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 646/scraper weightwatchers #657

Merged
merged 21 commits into from Oct 29, 2022

Conversation

bickerdyke
Copy link
Contributor

@bickerdyke bickerdyke commented Oct 19, 2022

Add scrapers for weight watchers public and restricted recipes.
fixes #646

recipe_scrapers/__init__.py Outdated Show resolved Hide resolved
recipe_scrapers/weightwatchers.py Outdated Show resolved Hide resolved
recipe_scrapers/weightwatchers.py Outdated Show resolved Hide resolved
recipe_scrapers/weightwatchers.py Outdated Show resolved Hide resolved
recipe_scrapers/weightwatchers.py Outdated Show resolved Hide resolved
recipe_scrapers/weightwatchers.py Show resolved Hide resolved
@jayaddison jayaddison mentioned this pull request Oct 20, 2022
3 tasks
@bickerdyke
Copy link
Contributor Author

I changed the code according to the suggestions, except the array comment where I had no idea if I should check array size or handle an exception

@hhursev
Copy link
Owner

hhursev commented Oct 28, 2022

Looks good to me, thanks! 🍻 I'll merge and bump version this weekend.

I like the

(*) offline saved files only. Page requires login

note and we'll start using it going forwards.

Would you mind sharing how you use the package? Looks like you are downloading a file + scrape the html separately. Your input will help us determine what updates to implement.

@bickerdyke
Copy link
Contributor Author

Saving a file html file from Browser and have that scraped is what I did for development and I let the test class feed it to the scraper.
In the real world, I'm hoping on tandoor sending the data from the bookmarklet or the big "try to import any text" to the new scraper.

@jayaddison
Copy link
Collaborator

I'm slightly uneasy about supporting login-required scrapers (even when offline), partly because of the test data alongside each scraper. Currently those test files are retrieved from public websites - anyone could/should see the same results, and anyone can later check/update/fix the scraper by retrieving it again.

@hhursev hhursev merged commit 954c5c6 into hhursev:main Oct 29, 2022
jayaddison pushed a commit that referenced this pull request Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for weightwatchers
4 participants