fix: incomplete justonecookbook #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayaddison
reviewed
Oct 17, 2022
recipe_scrapers/justonecookbook.py
Outdated
| return self.schema.ingredients() | ||
| ingredients = self.soup.find_all("li", {"class": "wprm-recipe-ingredient"}) | ||
| return [ | ||
| normalize_string(ingredient.get_text().replace("▢", "")) |
There was a problem hiding this comment.
Is the string replace call on this line necessary?
There was a problem hiding this comment.
did a fix for this, please check, thanks.
There was a problem hiding this comment.
Thanks - there's probably a reason why the site is including those x25a2 unicode entities in screen reader text.. but I don't know what that is. The fix is slightly more complicated but since the tests continue to pass, that looks good to me 👍
jayaddison
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the website on #489 . Found out the existing scaper is incomplete with bugs.