Cleanup: mypy.ini reduction #633
Conversation
…py on setuptools during our linting
…ibrary doesn't yet have typing information available)
| warn_return_any=False | ||
| warn_unreachable=False | ||
|
|
||
| strict_equality=True |
There was a problem hiding this comment.
I think we probably want to keep most of these due to the defaults for strictness options mostly being disabled:
https://mypy.readthedocs.io/en/stable/config_file.html#confval-strict_equality
I agree it's kind of icky, but one way to think of it is explicit over implicit
another thing, they may not error now, but they will help warn in the future
There was a problem hiding this comment.
Hmm, ok - understood that the checks we run could be made stricter. What would the costs and benefits of stricter checks be to our developers and maintainers?
| show_column_numbers=True | ||
| show_error_codes=True |
There was a problem hiding this comment.
for instance, these are all false by default:
https://mypy.readthedocs.io/en/stable/config_file.html#confval-show_error_codes
There was a problem hiding this comment.
and ditto for most of the others
There was a problem hiding this comment.
Ok, yep - enabling those seems like a good idea. Why are they disabled by default?
cc @sbdchd - it's totally possible that I misunderstand the reasoning behind some of the
mypy.iniconfiguration here (maybe local development environment differences?), but either way, runningmypy recipe_scrapers testslocally produces the same results before and after this change. The less configuration, the better, I reckon.