Fix ingredients for simplyrecipes.com scraper #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aside from the tiny lint fixup, this looks good to me 👍 |
jayaddison
approved these changes
Oct 9, 2022
Update the CSS class for ingredients. While here, also update the formatting of instructions such that colon isn't repeated twice. Refetch the test HTML file for verification. Test: python -m coverage run -m unittest tests.test_simplyrecipes
puradox
force-pushed
the
fix/simplyrecipes
branch
from
ec1c1f7
to
1211a4d
Compare
|
Thanks for the review! Ops didn't get the pre-commit hooks installed; ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the CSS class for ingredients. While here, also update the formatting of instructions such that colon isn't repeated twice. Refetch the test HTML file for verification.
Test: python -m coverage run -m unittest tests.test_simplyrecipes