Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added .venv to flake8 ignored directories #615

Merged
merged 4 commits into from Oct 1, 2022

Conversation

vabene1111
Copy link
Collaborator

I am not sure if this issue is special to my setup as I run on a windows PC but I noticed two things

  • the pre commit hook runs quite long
  • if i run flake8 manually it shows me tons of warnings for things in .venv

this PR adds ./venv/* to the ignored folders in the flake8 config. Since .venv is not in control of the project anyway it should not matter if flake is run there or not.

This speeds up the pre commit hook significantly and prevents any error messages from venv library files

speeds up check and prevents tons of messages when running manuallys
@jayaddison
Copy link
Collaborator

The objective here is good, and this problem does happen on other platforms too. I think this is fine to merge as a temporary improvement.

Roughly speaking though, I think that the symptom is that the developer experience for the library isn't yet as standardized as it could be.

I think that using tox (with configurations for unit testing and linting) seems to be a fairly standard approach across a lot of somewhat-popular Python libraries.

That has the benefit that both GitHub Actions and developers (and their IDEs -- and potentially pre-commit) could invoke the same consistent tox commands to run tests and linting. It'd be nice to provide auto-fix options where possible too.

@jayaddison jayaddison merged commit ccda81d into hhursev:main Oct 1, 2022
@vabene1111 vabene1111 added the hacktoberfest-accepted Hactoberfest 2022 label Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Hactoberfest 2022
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants