Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description method to WikiCookbook scraper #604

Merged
merged 1 commit into from Oct 1, 2022

Conversation

TheEpic-dev
Copy link
Contributor

Hey. This PR implements the description() method for the wikibooks scraper. I updated the unit tests, and also manually tested different types of recipes, like:

Copy link
Collaborator

@bfcarpio bfcarpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to double check the docs just to make sure.It looks odd to use find() in a loop construct when it would appear to only return one item.

recipe_scrapers/wikicookbook.py Show resolved Hide resolved
recipe_scrapers/wikicookbook.py Show resolved Hide resolved
@bfcarpio
Copy link
Collaborator

bfcarpio commented Oct 1, 2022

Looks good! 🍺 Thank you very much!

@bfcarpio bfcarpio merged commit 03aa8b3 into hhursev:main Oct 1, 2022
@TheEpic-dev TheEpic-dev deleted the implement-wikibooks-description branch October 1, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants