Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for www.emmikochteinfach.de #603

Merged

Conversation

derteufelqwe
Copy link
Contributor

I have added a the scraper for www.emmikochteinfach.de
The receipe in the test is https://emmikochteinfach.de/klassisches-rindergulasch/

@jayaddison
Copy link
Collaborator

Hi @derteufelqwe - this looks good, thank you!

There are some lint check failures which can be fixed by running the black code formatter on your code.

Also since this opened, we have merged #601 which added support for mypy Python type checks. If you can pull and merge the latest changes from the main branch into this one, then those will run before we integrate your changes.

@derteufelqwe
Copy link
Contributor Author

I somehow forgot I wanted to update this ;P
This should fix the issues.

Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @derteufelqwe

@jayaddison jayaddison merged commit ceddab6 into hhursev:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants