Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scraper for lekkerensimpel.com #507

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

danielpalstra
Copy link
Contributor

This PR adds a scraper for dutch recipe site https://lekkerensimpel.com

Copy link
Collaborator

@jayaddison jayaddison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you @danielpalstra!

An optional request: could you consider adding test coverage on the natural language detection for the scraper?

Example:

def test_language(self):
self.assertEqual("en-AU", self.harvester_class.language())

@coveralls
Copy link

coveralls commented Mar 9, 2022

Coverage Status

Coverage decreased (-0.08%) to 95.292% when pulling 40886d0 on danielpalstra:lekkersimpel into bb20d6e on hhursev:main.

@danielpalstra
Copy link
Contributor Author

@jayaddison I added the language method as requested.

@jayaddison jayaddison merged commit d1cdbbd into hhursev:main Mar 10, 2022
@jayaddison
Copy link
Collaborator

Thanks again @danielpalstra - this is now available as part of recipe-scrapers v13.20.0, as published on PyPi.

@danielpalstra
Copy link
Contributor Author

Thanks again @danielpalstra - this is now available as part of recipe-scrapers v13.20.0, as published on PyPi.

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants