Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ignoring W191. #627

Merged
merged 6 commits into from Apr 5, 2022
Merged

Add support for ignoring W191. #627

merged 6 commits into from Apr 5, 2022

Conversation

MinekPo1
Copy link
Contributor

@MinekPo1 MinekPo1 commented Mar 5, 2022

Requested in #252, #207, #471 and others.

While a hacky solution was given (ignoring E101 or/and E111), it entirely disables re-indenting, which is undesired.

I believe all tests should pass, however some tests clearly fail on my machine due to how my environment is set up.

@MinekPo1
Copy link
Contributor Author

MinekPo1 commented Mar 6, 2022

I'm not sure how these tests fail to be frankly honest.

@MinekPo1
Copy link
Contributor Author

MinekPo1 commented Mar 6, 2022

Got it. Sneaky removal of leaning whitespace.

@codecov-commenter
Copy link

Codecov Report

Merging #627 (3ab866b) into master (889805a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #627   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files           1        1           
  Lines        2404     2406    +2     
=======================================
+ Hits         2352     2354    +2     
  Misses         52       52           
Impacted Files Coverage Δ
autopep8.py 97.83% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 889805a...3ab866b. Read the comment docs.

@hhatto hhatto self-requested a review March 8, 2022 05:04
Copy link
Owner

@hhatto hhatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍

@hhatto hhatto merged commit 74da7ae into hhatto:master Apr 5, 2022
@hhatto
Copy link
Owner

hhatto commented Apr 5, 2022

sorry for late reply.
merge this.

Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants